ktmud opened a new pull request #10293:
URL: https://github.com/apache/incubator-superset/pull/10293


   ### SUMMARY
   
   Table chart has stopped using the default time column due to recent refactor 
to control utils (#10224, #10264, #10284). Other charts somehow weren't 
impacted.
   
   The root cause is that `mapStateToProps` for the Time Column control will 
update `control.default` that wasn't picked by the re-run of `mapStateToProps` 
in `getInitialState`.
   
   Refactored `applyMapStateToPropsToControl` so that everything the map 
function updates `default` or `value`, it will always be picked up by 
`getControlState`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   
   Added an integration test
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to