ktmud commented on a change in pull request #10293:
URL:
https://github.com/apache/incubator-superset/pull/10293#discussion_r453800678
##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.jsx
##########
@@ -66,15 +66,14 @@ class ControlPanelsContainer extends React.Component {
renderControl({ name, config }) {
const { actions, controls, exploreState, form_data: formData } =
this.props;
const { visibility } = config;
+
// If the control item is not an object, we have to look up the control
data from
// the centralized controls file.
// When it is an object we read control data straight from `config` instead
const controlData = {
- ...controls[name],
...config,
+ ...controls[name],
name,
- // apply current value in formData
- value: formData[name],
Review comment:
This is not needed since `controls[name].value` is always in sync with
`formData[name]` per
https://github.com/apache/incubator-superset/blob/700429f431d20b624e886cf554b2b493793448be/superset-frontend/src/explore/reducers/exploreReducer.js#L100
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
