villebro commented on pull request #9962: URL: https://github.com/apache/incubator-superset/pull/9962#issuecomment-657983367
@ktmud My original idea behind adding the `queryFields` mapping was to make it as simple as possible to create viz plugins, and avoid the need to use the `buildQuery` hook unless post transforms would be required. Another thought behind it was to make it possible to transfer state between controls when switching chart types (selections from `metric` and `secondary_metric` flowing into `metrics` and vice versa). However, I've also started having similar thoughts, as `buildQuery` is very simple to construct, and I suspect doing some form of tweaking will be required in practically all viz'. I agree that having `queryFields` convolute `formData` that is persisted in the metadata is not a good thing, so in the interest of keeping it as lean as possible I'm all for removing it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
