etr2460 opened a new pull request #10350: URL: https://github.com/apache/incubator-superset/pull/10350
### SUMMARY Sometimes I feel like eslint doesn't catch enough of my silly mistakes. Sometimes that's because my mistakes are exceedingly bad, but it turns out other times that's because we disable a bunch of the standard eslint rules from the airbnb standard set. I've re-enabled 2 in this PR, but will likely do more in the future if we think this is a good direction to go in. I'm hoping that these 2 rules are accepted by everyone, so it should be an easy change ### TEST PLAN CI, ensure main functionality in dashboard, sql lab, and explore still works ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API to: @ktmud @rusackas @graceguo-supercat @lilykuang ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
