[GitHub] [incubator-superset] nytai opened a new pull request #10369: fix: allow creating option in table select in dataset add modal

[GitBox]

nytai opened a new pull request #10369:
URL: https://github.com/apache/incubator-superset/pull/10369


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   There is currently an issue with adding google sheets as datasets. The 
dataset add modal expects there to be a schema selected before table select is 
enabled. Since google sheets don't have schemas there is no way to add a google 
sheet as a dataset. The fix is:
   - Allow creating option in dataset add modal. Google sheets urls can now be 
pasted in the select field.
   - schema is now optional. Simply leave it blank to add a google sheet. 
   
   Trade Offs: there will now be a higher possibility for errors as users will 
be able to submit the form without shema and the table option now allows input 
so users can paste non-existent tables into the select field.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   <img width="1684" alt="Screen Shot 2020-07-20 at 5 34 40 PM" 
src="https://user-images.githubusercontent.com/10255196/87999377-6e7d1480-caaf-11ea-862c-046a67bc1f3d.png";>
   <img width="908" alt="Screen Shot 2020-07-20 at 5 35 00 PM" 
src="https://user-images.githubusercontent.com/10255196/87999380-6f15ab00-caaf-11ea-9817-60843a7e9b89.png";>
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - can add a google sheet as a dataset. 
   - can add a regular table as a dataset
   - unit tests pass.
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org