chuancyzhang commented on pull request #10377:
URL: 
https://github.com/apache/incubator-superset/pull/10377#issuecomment-662318963


   > It's not better to handle this like `DistribuationBarViz` handled this?
   > And do this for other classes
   > 
https://github.com/apache/incubator-superset/blob/9b8da402955d3adcebaf7b711b79e0cfd720d025/superset/viz.py#L1624-L1627
   
   please review this 
PR[#10390](https://github.com/apache/incubator-superset/pull/10390). we have 
been tested in our development.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to