rusackas commented on a change in pull request #10402:
URL:
https://github.com/apache/incubator-superset/pull/10402#discussion_r459206031
##########
File path: superset-frontend/src/components/Menu/Menu.jsx
##########
@@ -59,6 +59,28 @@ const StyledHeader = styled.header`
flex-direction: column;
justify-content: center;
}
+
+ .navbar-nav > li > a {
+ &:after {
+ content: '';
+ position: absolute;
+ bottom: -3px;
+ left: 0;
+ width: 100%;
+ height: 3px;
+ background-color: #20a7c9;
Review comment:
```suggestion
background-color: ${({ theme }) => theme.colors.primary.base};
```
And actually, just so everyone reading this is aware, there's an extra
benefit of doing it this way, which I haven't really demonstrated to folks....
Since the `supersetTheme` is currently applied at the top of the `App` using
a `ThemeProvider`, we get to (eventually) expand this with some JS to merge a
user's preferences/config onto the theme... something like so:
`<ThemeProvider theme={customizeTheme(supersetTheme, userThemePrefs)}><App
/></ThemeProvider>` and/or employ any number of pre-rolled themes, e.g.
`<ThemeProvider theme={supersetTheme(dark)}><App /></ThemeProvider>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
