aspedrosa opened a new pull request #10410:
URL: https://github.com/apache/incubator-superset/pull/10410


   ### SUMMARY
   Currently there is a hard coded row limit on FilterBox.
   I added the row limit control to the filter box visualization control panel 
so the user can customize this limit.
   However the new default limit is 50000, imposed by the control itself.
   
   There was another pull request (#8101) that fixed this but placed the row 
limit within each field being filtered, but this leads to having several row 
limit selects.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
![filterbox_before](https://user-images.githubusercontent.com/23409890/88283673-ca2fe380-cce3-11ea-8f62-0ca9dea83e80.png)
   
   After:
   
![filterbox_after](https://user-images.githubusercontent.com/23409890/88283692-d2881e80-cce3-11ea-85ea-839e916459cc.png)
   
   ### TEST PLAN
   Suppose that the rendering of controls cover this :thinking:
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: #7971
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to