john-bodley commented on a change in pull request #10427:
URL:
https://github.com/apache/incubator-superset/pull/10427#discussion_r460577100
##########
File path: superset/cli.py
##########
@@ -197,18 +197,17 @@ def set_database_uri(database_name: str, uri: str) ->
None:
)
def refresh_druid(datasource: str, merge: bool) -> None:
"""Refresh druid datasources"""
- session = db.session()
Review comment:
This is the same session per
[here](https://docs.sqlalchemy.org/en/13/orm/contextual.html#contextual-thread-local-sessions)
and added unnecessary obfuscation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
