mistercrunch commented on a change in pull request #10446:
URL: 
https://github.com/apache/incubator-superset/pull/10446#discussion_r461311401



##########
File path: superset-frontend/src/components/ListView/Filters.tsx
##########
@@ -63,6 +66,7 @@ const filterSelectTheme: PartialThemeConfig = {
   spacing: {
     baseUnit: 2,
     minWidth: '5em',
+    fontSize: FONT_SIZE,

Review comment:
       wait I don't think that works, I need to outright import the theme I 
think

##########
File path: superset-frontend/src/components/ListView/Filters.tsx
##########
@@ -63,6 +66,7 @@ const filterSelectTheme: PartialThemeConfig = {
   spacing: {
     baseUnit: 2,
     minWidth: '5em',
+    fontSize: FONT_SIZE,

Review comment:
       wait I'm not in a text string here, this is a good old JS object... I 
think we'd have to convert those objects to emotion first...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to