mistercrunch commented on a change in pull request #10444:
URL:
https://github.com/apache/incubator-superset/pull/10444#discussion_r461288858
##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -83,18 +83,23 @@ function ColumnCollectionTable({
<Field
fieldKey="expression"
label={t('SQL Expression')}
- control={<TextControl />}
+ control={
+ <TextAreaControl
Review comment:
That looked pretty big in the <tr>, would look bad if there was many of
these stacked... We may want to inline it.
##########
File path: superset-frontend/src/datasource/DatasourceEditor.jsx
##########
@@ -83,18 +83,23 @@ function ColumnCollectionTable({
<Field
fieldKey="expression"
label={t('SQL Expression')}
- control={<TextControl />}
+ control={
+ <TextAreaControl
Review comment:
That looked pretty big in the `<tr>`, would look bad if there was many
of these stacked... We may want to inline it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
