JasonD28 opened a new pull request #10454:
URL: https://github.com/apache/incubator-superset/pull/10454
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
- Added unit testing for some functionality introduced through SQL-based
email alerts
- Removed unused fields from AlertModelView
- Fix retention of past calls made to alert schedules
- The celery alerting task is meant to be invoked every minute, however
the previous implementation of `schedule_window()` ignored the timestamp of
previous calls to alerting schedules, this resulted in alerts being sent out
every time the task was invoked
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
