etr2460 commented on a change in pull request #10458:
URL:
https://github.com/apache/incubator-superset/pull/10458#discussion_r462673592
##########
File path:
superset-frontend/src/explore/components/controls/DateFilterControl.jsx
##########
@@ -82,8 +82,8 @@ const DEFAULT_SINCE = moment()
const DEFAULT_UNTIL = moment().utc().startOf('day').format(MOMENT_FORMAT);
const SEPARATOR = ' : ';
const FREEFORM_TOOLTIP = t(
- 'Superset supports smart date parsing. Strings like `last sunday` or ' +
- '`last october` can be used.',
+ 'Superset supports smart date parsing. Strings like `3 weeks ago`, `last
sunday` or ' +
Review comment:
oh, one thing I missed if we do stick with the current approach. Can you
add the Oxford Comma before `or` here? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
