ktmud commented on pull request #10475: URL: https://github.com/apache/incubator-superset/pull/10475#issuecomment-666930081
I'd prefer not to use react hooks in `setTimeout` or `setTiemout` in hooks since every time I used it, it turned out to be more problematic than the problem it tried to solve---and there was almost always a more robust solution. Could you confirm which browsers and versions you tested are still seeing the problem with `onExiting` as the solution? Because I have tested Chrome, Safari and Firefox on Mac, and all of them cannot reproduce the bug. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
