john-bodley commented on a change in pull request #10499:
URL:
https://github.com/apache/incubator-superset/pull/10499#discussion_r464020551
##########
File path: setup.py
##########
@@ -65,7 +65,7 @@ def get_git_sha():
packages=find_packages(),
include_package_data=True,
zip_safe=False,
- scripts=["superset/bin/superset"],
+ entry_points={"console_scripts": ["superset=superset.cli:superset"]},
Review comment:
`mypy` via `pre-commit` had a conflict between `superset/__init__.py`
and this script and thus I opted for an alternative formulation of the script
definiton.
##########
File path: .pre-commit-config.yaml
##########
@@ -15,28 +15,34 @@
# limitations under the License.
#
repos:
-- repo: https://github.com/ambv/black
Review comment:
ABC.
##########
File path: .pylintrc
##########
@@ -25,7 +25,7 @@
# Add files or directories to the blacklist. They should be base names, not
# paths.
-ignore=CVS
+ignore=CVS,migrations
Review comment:
Required since `migrations` is now a module so it can be ignored my
`mypy`.
##########
File path: scripts/permissions_cleanup.py
##########
@@ -16,13 +16,15 @@
# under the License.
from collections import defaultdict
-from superset import sm
+from superset import security_manager
Review comment:
This file was not previously type checked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
