etr2460 opened a new pull request #10551: URL: https://github.com/apache/incubator-superset/pull/10551
### SUMMARY When this empty div was added, it broke `ParentSize` a few components down the stack, resulting in embedded charts rendering with 0 height. This fixes the issue. I was trying to figure out a good way to write a unit test for this, but couldn't since it involves so many layers of components. Perhaps a snapshot test would be valuable in the future though ### TEST PLAN CI, test an embedded chart ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API to: @rusackas @graceguo-supercat @ktmud ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
