JasonD28 opened a new pull request #10579:
URL: https://github.com/apache/incubator-superset/pull/10579


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Used scheduled report implementation of dashboard screenshots to add support 
for dashboards on SQL-based alerting. Also updated email alerts to support 
emails with no screenshot.
   
   Form:
   ![Screen Shot 2020-08-11 at 11 23 54 
AM](https://user-images.githubusercontent.com/32852580/89934975-42dcde00-dbc6-11ea-9489-12fba0854fa3.png)
   Slack:
   <img width="564" alt="Screen Shot 2020-08-11 at 11 26 19 AM" 
src="https://user-images.githubusercontent.com/32852580/89934990-483a2880-dbc6-11ea-8990-4f37de1b5692.png";>
   Email:
   ![Screen Shot 2020-08-11 at 11 26 37 
AM](https://user-images.githubusercontent.com/32852580/89934998-4c664600-dbc6-11ea-81a0-0ef280b16aba.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - [x] local test
   - [ ] dropbox staging
   - [ ] dropbox prob
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to