john-bodley commented on a change in pull request #10593:
URL:
https://github.com/apache/incubator-superset/pull/10593#discussion_r471057207
##########
File path: tests/conftest.py
##########
@@ -14,18 +14,27 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+# isort:skip_file
Review comment:
Why is this necessary? I prefer the previous logic on 23.
##########
File path: superset/db_engine_specs/hive.py
##########
@@ -51,6 +51,27 @@
hive_poll_interval = conf.get("HIVE_POLL_INTERVAL")
+def upload_to_s3(filename: str, upload_prefix: str, table: Table) -> str:
+ bucket_path = config["CSV_TO_HIVE_UPLOAD_S3_BUCKET"]
+
+ if not bucket_path:
+ logger.info("No upload bucket specified")
+ raise Exception(
+ "No upload bucket specified. You can specify one in the config
file."
+ )
+ # Optional dependency
+ import boto3 # pylint: disable=import-error
Review comment:
Can we place the import at the start of the function?
##########
File path: requirements/testing.in
##########
@@ -16,7 +16,10 @@
#
-r base.in
-r integration.in
+ipdb
+ipython==7.16.1
Review comment:
Nit. ABC. Also why pin `ipython`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
