villebro commented on a change in pull request #10619:
URL:
https://github.com/apache/incubator-superset/pull/10619#discussion_r471419375
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1247,35 +1254,45 @@ def fetch_metadata(self, commit: bool = True) -> None:
any_date_col = None
db_engine_spec = self.database.db_engine_spec
db_dialect = self.database.get_dialect()
- dbcols = (
- db.session.query(TableColumn)
- .filter(TableColumn.table == self)
- .filter(or_(TableColumn.column_name == col.name for col in
table_.columns))
Review comment:
I'm not sure what the intent here was, but I don't see any scenario
where we want to bring in columns from another table with the same column names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
