etr2460 commented on a change in pull request #10625:
URL:
https://github.com/apache/incubator-superset/pull/10625#discussion_r472319679
##########
File path: superset-frontend/src/components/Modal.tsx
##########
@@ -31,7 +31,7 @@ interface ModalProps {
primaryButtonType?: 'primary' | 'danger';
show: boolean;
title: React.ReactNode;
- bsSize?: 'xs' | 'xsmall' | 'sm' | 'small' | 'medium' | 'lg' | 'large';
+ bsSize?: 'sm' | 'small' | 'lg' | 'large';
Review comment:
I looked at react-bootstrap's docs because i couldn't believe that both
`sm` and `small` were supported for this, but they seem to be.
That said, there's no reason we can't provide a more clear and consistent
interface in our Modal wrapper. Maybe we should only support `small` and
`large`? The types should still work and it'll ensure one standard way to
define this size throughout Superset
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
