nytai commented on a change in pull request #10606:
URL:
https://github.com/apache/incubator-superset/pull/10606#discussion_r473498423
##########
File path: superset-frontend/src/components/ListViewCard/index.tsx
##########
@@ -163,31 +177,70 @@ function ListViewCard({
<GradientContainer>
<CardCoverImg
src={imgURL}
- onError={e => {
- e.currentTarget.src = imgFallbackURL;
- }}
+ fallback={imgFallbackURL}
+ isLoading={loading}
/>
</GradientContainer>
</a>
<CoverFooter className="cover-footer">
- {coverLeft && <CoverFooterLeft>{coverLeft}</CoverFooterLeft>}
- {coverRight && <CoverFooterRight>{coverRight}</CoverFooterRight>}
+ {!loading && coverLeft && (
+ <CoverFooterLeft>{coverLeft}</CoverFooterLeft>
+ )}
+ {!loading && coverRight && (
+ <CoverFooterRight>{coverRight}</CoverFooterRight>
+ )}
</CoverFooter>
</Cover>
}
>
- <Card.Meta
- title={
- <>
- <TitleContainer>
- <TitleLink href={url}>{title}</TitleLink>
- {titleRight && <div className="title-right"> {titleRight}</div>}
- <div className="card-actions">{actions}</div>
- </TitleContainer>
- </>
- }
- description={description}
- />
+ {loading && (
+ <Card.Meta
+ title={
+ <>
+ <TitleContainer>
+ <Skeleton.Input
Review comment:
I think I had something like that originally but found it quite hard to
read. I think the slightly less DRYness is worth if for higher code
readability. It's much easier to figure out "Am I dealing with the skeleton or
the actual component" if the two are separate blocks of jsx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
