nytai commented on pull request #10642: URL: https://github.com/apache/incubator-superset/pull/10642#issuecomment-676887070
@riahk took a shot at sharing a menu component between Datasets and Databases, but quickly realized that only half the menu is shared. There's logic that conditionally adds the "Bulk Select" and "+Dataset" actions, those are specific to the Datasets view. Instead I just moved the props that are shared into a common file. I also renamed the "Welcome" app to something more semantic and moved the Welcome component under `src/views/CRUD` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
