Ofeknielsen commented on a change in pull request #10594:
URL:
https://github.com/apache/incubator-superset/pull/10594#discussion_r476308187
##########
File path: superset/models/dashboard.py
##########
@@ -496,3 +548,13 @@ def event_after_dashboard_changed( # pylint:
disable=unused-argument
if is_feature_enabled("THUMBNAILS_SQLA_LISTENERS"):
sqla.event.listen(Dashboard, "after_insert", event_after_dashboard_changed)
sqla.event.listen(Dashboard, "after_update", event_after_dashboard_changed)
+
+
+sqla.event.listen(Dashboard, "after_insert", SecuredMixin.after_insert)
Review comment:
some more details
##########
File path: superset/models/dashboard.py
##########
@@ -496,3 +548,13 @@ def event_after_dashboard_changed( # pylint:
disable=unused-argument
if is_feature_enabled("THUMBNAILS_SQLA_LISTENERS"):
sqla.event.listen(Dashboard, "after_insert", event_after_dashboard_changed)
sqla.event.listen(Dashboard, "after_update", event_after_dashboard_changed)
+
+
+sqla.event.listen(Dashboard, "after_insert", SecuredMixin.after_insert)
Review comment:
some more details
We implemented it by subscribing to after_insert event and insert the new
objects by using the the passed connection
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
