bkyryliuk commented on a change in pull request #10605:
URL:
https://github.com/apache/incubator-superset/pull/10605#discussion_r476645338
##########
File path: superset/models/alerts.py
##########
@@ -100,3 +119,187 @@ class AlertLog(Model):
@property
def duration(self) -> int:
return (self.dttm_end - self.dttm_start).total_seconds()
+
+
+class Observer(Model):
+
+ __tablename__ = "alert_observers"
+
+ id = Column(Integer, primary_key=True)
+ name = Column(String(150), nullable=False)
+ observer_type = Column(Enum(AlertObserverType))
+ validation_type = Column(Enum(AlertValidationType))
Review comment:
let's keep it simple and assume that observers collect numbers e.g.
floats
add a comment to the observer value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
