bkyryliuk commented on a change in pull request #10675:
URL:
https://github.com/apache/incubator-superset/pull/10675#discussion_r476681183
##########
File path: tests/core_tests.py
##########
@@ -576,6 +576,28 @@ def test_warm_up_cache(self):
)
assert len(data) > 0
+ dashboard = self.get_dash_by_slug("world_health")
+ slc = self.get_slice("World's Population", db.session)
+
+ self.assertEqual(
+ self.get_json_resp(
+
f"/superset/warm_up_cache?dashboard_id={dashboard.id}&slice_id={slc.id}"
+ ),
+ [{"slice_id": slc.id, "viz_error": None, "viz_status": "success"}],
+ )
+
+ self.assertEqual(
Review comment:
use assert == as per pytest convention
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
