nytai commented on a change in pull request #10676:
URL:
https://github.com/apache/incubator-superset/pull/10676#discussion_r476723288
##########
File path: superset/sql_lab.py
##########
@@ -183,7 +183,6 @@ def get_sql_results( # pylint: disable=too-many-arguments
log_params=log_params,
)
except Exception as ex: # pylint: disable=broad-except
- logger.error("Query %d", query_id)
Review comment:
This doesn't seem very useful, all that ends up being logged is
something like
```
Query 694: <class 'pymssql.ProgrammingError'>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
