villebro commented on a change in pull request #10674:
URL:
https://github.com/apache/incubator-superset/pull/10674#discussion_r478279885
##########
File path: superset/config.py
##########
@@ -263,7 +263,7 @@ def _try_json_readsha( # pylint: disable=unused-argument
# Grant public role the same set of permissions as for a selected builtin role.
# This is useful if one wants to enable anonymous users to view
# dashboards. Explicit grant on specific datasets is still required.
-PUBLIC_ROLE_LIKE = "Gamma"
+PUBLIC_ROLE_LIKE = None
Review comment:
I assume we should add the optional type, too:
```suggestion
PUBLIC_ROLE_LIKE: Optional[str] = None
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
