villebro commented on a change in pull request #10707:
URL:
https://github.com/apache/incubator-superset/pull/10707#discussion_r479054033
##########
File path: superset/typing.py
##########
@@ -25,7 +25,7 @@
str, str, Optional[str], Optional[str], Optional[int], Optional[int], bool
]
DbapiDescription = Union[List[DbapiDescriptionRow], Tuple[DbapiDescriptionRow,
...]]
-DbapiResult = List[Union[List[Any], Tuple[Any, ...]]]
+DbapiResult = Sequence[Union[List[Any], Tuple[Any, ...]]]
Review comment:
for some reason `MyPy` was giving me errors on this locally (I'm
probably running a newer version than CI). As I know some Dbapis are actually
returning tuples, I think this makes sense anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
