nytai commented on a change in pull request #10649:
URL:
https://github.com/apache/incubator-superset/pull/10649#discussion_r479558774
##########
File path: superset-frontend/spec/helpers/theming.ts
##########
@@ -51,5 +51,5 @@ export function styledShallow(
theme: supersetTheme,
...options?.wrappingComponentProps,
},
- });
+ }).dive();
Review comment:
Should this live here or in the tests using this wrapper? I see it
called here:
https://github.com/apache/incubator-superset/pull/10649/files#diff-7dabcc63260bfc89250effddae3e73d5R49
are both necessary?
##########
File path: superset-frontend/src/views/CRUD/data/dataset/Button.tsx
##########
@@ -1,72 +0,0 @@
-/**
Review comment:
🙌 🥳 🎉
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
