rusackas opened a new pull request #10722: URL: https://github.com/apache/incubator-superset/pull/10722
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> This makes some margins intrinsic to the Label component. These margins are NOT applied on the left side of the `first-of-type` or right side of `last-of-type`. This means we shouldn't need the `m-r-5` classes` in any Labels. We also don't really need the `pointer` class on labels with an `onClick` prop, so I killed that too. One example of a `last-of-type` that still DOES need margin on the right is in the screenshot below, but I added that margin to the context of the wrapping container, which is what we should _probably_ be doing where exceptions apply to the rule.  ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN <!--- What steps should be taken to verify the changes --> Storybook, in-situ viewing, CI passing. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [x] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
