villebro commented on a change in pull request #10706:
URL:
https://github.com/apache/incubator-superset/pull/10706#discussion_r479647524
##########
File path: superset/db_engine_specs/oracle.py
##########
@@ -58,3 +63,14 @@ def epoch_to_dttm(cls) -> str:
@classmethod
def epoch_ms_to_dttm(cls) -> str:
return "TO_DATE('1970-01-01','YYYY-MM-DD')+(1/24/60/60/1000)*{col}"
+
+ @classmethod
+ def fetch_data(cls, cursor: Any, limit: int) -> List[Tuple]:
Review comment:
The signature of this method has changed as of #10707 making `limit:
Optional[int] = None`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
