villebro commented on a change in pull request #10706:
URL: 
https://github.com/apache/incubator-superset/pull/10706#discussion_r479724124



##########
File path: superset/db_engine_specs/oracle.py
##########
@@ -15,7 +15,12 @@
 # specific language governing permissions and limitations
 # under the License.
 from datetime import datetime
-from typing import Optional
+from typing import (
+    Any,
+    List,
+    Optional,
+    Tuple
+)

Review comment:
       This is what `isort` would do:
   ```suggestion
   from typing import Any, List, Optional, Tuple
   ```
   Check 
https://github.com/apache/incubator-superset/blob/master/CONTRIBUTING.md for 
details on how to install pre-commit hooks to do this automatically:
   
   ```bash
   pip3 install -r requirements/integration.txt
   pre-commit install
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to