willbarrett commented on a change in pull request #10678:
URL:
https://github.com/apache/incubator-superset/pull/10678#discussion_r480242289
##########
File path: superset/models/core.py
##########
@@ -87,6 +87,18 @@ class KeyValue(Model): # pylint:
disable=too-few-public-methods
value = Column(Text, nullable=False)
+class CacheKey(Model): # pylint: disable=too-few-public-methods
+
+ """Used for any type of key-value store"""
Review comment:
Let's make the description a bit more accurate - I would have thought
this model was itself a key/value store, rather than saved references to keys
in a different cache back-end.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
