villebro commented on a change in pull request #10811:
URL:
https://github.com/apache/incubator-superset/pull/10811#discussion_r484681966
##########
File path: superset/db_engine_specs/mssql.py
##########
@@ -46,7 +46,7 @@ class MssqlEngineSpec(BaseEngineSpec):
"PT0.5H": "DATEADD(minute, DATEDIFF(minute, 0, {col}) / 30 * 30, 0)",
"PT1H": "DATEADD(hour, DATEDIFF(hour, 0, {col}), 0)",
"P1D": "DATEADD(day, DATEDIFF(day, 0, {col}), 0)",
- "P1W": "DATEADD(week, DATEDIFF(week, 0, {col}), 0)",
Review comment:
With regard to the proposed change here, and given the ambiguity of what
`P1W` means, I think this change makes sense as a "best effort" weekly time
grain (for the lack of a better term). But if you could add the explicit Sunday
and Monday starting grains, then users could have the option of using either
the local week definition, or a fixed one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
