[GitHub] [incubator-superset] john-bodley opened a new pull request #10823: fix: Making the database read-only

[GitBox]

john-bodley opened a new pull request #10823:
URL: https://github.com/apache/incubator-superset/pull/10823


   ### SUMMARY
   
   This PR makes a few related consistency updates to ensure that the 
database/cluster et al. is read-only either in the FAB CRUD or React data 
editor. Note one could reason that you could potential make the schema, table, 
etc. read-only, though my sense is that is that could be somewhat 
controversial. 
   
   Specially this PR: 
   
   1. For the React data editor makes the database read-only which is 
consistent with the FAB CRUD views.
   2. Moves the React data editor warning above the tabs, i.e., users should be 
aware that changing any fields (metrics, columns, etc.) will impact all charts 
using said datasource.
   3. For the Druid datasource CRUD view makes the cluster and datasource name 
read only. The cluster is akin to the database and thus this ensures 
consistency. Additionally the Druid datasource name is fixed hence this was 
also defined as read-only.  
   
   @dpgaspar I noticed that there seems to have been a regression in FAB and 
the read-only selector logic which we are using (per the 
[documentation](https://flask-appbuilder.readthedocs.io/en/latest/advanced.html#forms-readonly-fields))
 no longer works. I've also verified this using the FAB examples and was 
wondering whether you could look into it?
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### BEFORE
   
   <img width="805" alt="Screen Shot 2020-09-09 at 4 43 44 PM" 
src="https://user-images.githubusercontent.com/4567245/92665525-ab010b80-f2bb-11ea-8a76-7c234f041cc4.png";>
   
   #### AFTER
   
   <img width="803" alt="Screen Shot 2020-09-09 at 4 28 33 PM" 
src="https://user-images.githubusercontent.com/4567245/92665391-4b0a6500-f2bb-11ea-991f-2726b3f04417.png";>
   
   ### TEST PLAN
   
   Tested locally. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org