bkyryliuk commented on a change in pull request #10819:
URL:
https://github.com/apache/incubator-superset/pull/10819#discussion_r486600066
##########
File path: superset/tasks/alerts/observer.py
##########
@@ -20,22 +20,22 @@
from typing import Optional
import pandas as pd
+from sqlalchemy.orm import Session
-from superset import db
from superset.models.alerts import Alert, SQLObservation
from superset.sql_parse import ParsedQuery
logger = logging.getLogger("tasks.email_reports")
-def observe(alert_id: int) -> Optional[str]:
+def observe(alert_id: int, session: Session) -> Optional[str]:
Review comment:
good point, added comments and issue reference
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
