ktmud opened a new pull request #10850:
URL: https://github.com/apache/incubator-superset/pull/10850


   ### SUMMARY
   
   Add custom dashboard css to server side rendering so the page doesn't have 
to repaint when refresh.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Before
   
   Since custom CSS is added after dashboard is loaded, when loading a 
dashboard, you may see an annoying repaint:
   
   
![load-repaint](https://user-images.githubusercontent.com/335541/92984619-55199880-f460-11ea-89cd-fd79fd57c1f7.gif)
   
   #### After
   
   No repaint when refreshing the page:
   
   
![no-repaint](https://user-images.githubusercontent.com/335541/92984648-85f9cd80-f460-11ea-9b2c-e93f3cd10eb3.gif)
   
   
   ### TEST PLAN
   
   Manual testing.
   
   1. Go add some custom CSS to a dashboard. Following is used in the 
screenshots:
      ```css
      body {
        font-family: monospace;
      }
      #app-menu {
        display: none;
      }
      ```
   2. Save and refresh the page.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to