john-bodley commented on a change in pull request #10887:
URL:
https://github.com/apache/incubator-superset/pull/10887#discussion_r488421520
##########
File path: superset/utils/cache_manager.py
##########
@@ -24,28 +24,24 @@ class CacheManager:
def __init__(self) -> None:
super().__init__()
- self._tables_cache = None
- self._cache = None
Review comment:
It's interesting that the
```python
@property
def cache(self) -> Cache:
return self._cache
```
method didn't barf from a MyPy perspective given that `self._cache` is
actually `Optional[Cache]` per the definition on line 28.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
