ktmud opened a new pull request #10901: URL: https://github.com/apache/incubator-superset/pull/10901
### SUMMARY Minor optimization for `eslintrc` configs: 1. Instead of disabling `import/no-extraneous-dependencies`, use `env: node` and set appropriate import resolver for `webpack*.js` (ref: https://github.com/benmosher/eslint-plugin-import/issues/1396#issuecomment-511007063) 2. Move `settings` to top of the file so it's more discoverable. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN CI ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
