nytai commented on a change in pull request #10922:
URL:
https://github.com/apache/incubator-superset/pull/10922#discussion_r489806143
##########
File path: superset-frontend/src/views/CRUD/data/common.ts
##########
@@ -36,8 +36,8 @@ export const commonMenuData = {
{
name: 'Saved Queries',
label: t('Saved Queries'),
- url: '/sqllab/my_queries/',
- usesRouter: false,
+ url: '/savedqueryview/list/',
+ usesRouter: true,
Review comment:
Yup, since databases is already done this shouldn't be a problem. I'm
planning to remove the `SIP_34_DATABASE_UI ` flag soon. This is mainly to avoid
users landing on a blank/under construction page when
`ENABLE_REACT_CRUD_VIEWS=True`. If you want to add a feature flag check here
you're welcome to, but I'd say for now it's fine if it routes through the
backend and we'll switch this on once the saved queries ui is done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
