nytai commented on a change in pull request #10955:
URL:
https://github.com/apache/incubator-superset/pull/10955#discussion_r491075739
##########
File path: superset/datasets/api.py
##########
@@ -207,7 +207,7 @@ def post(self) -> Response:
except DatasetInvalidError as ex:
return self.response_422(message=ex.normalized_messages())
except DatasetCreateFailedError as ex:
- logger.error(
+ logger.info(
Review comment:
I think we were seeing some instances of dataset creation failure,
specifically the unique constraint violation for table_name. Since this error
is already bubbled up to the user, and is likely to occur fairly often, I think
it makes sense to reduce the noise around this. The fix is likely to add
another case for the unique violation, instead of converting all of these to
info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
