kgabryje commented on pull request #10870: URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-695840072
> @mistercrunch I rebased this PR on the newest master and retriggered the CI a couple of times but it keeps failing the cypress tests (explore/AdhocMetrics.test.ts). @eschutho do you have any idea how we could fix this? And just as I wrote this comment I figured that the issue is in my code and not in Cypress... I accessed `event.target.value` in an async function and React's good old event pooling made sure that the `target` field was undefined. It's fixed now - I moved accessing the value to synchronous part of event handler. Sorry for confusion! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
