kgabryje opened a new pull request #10981:
URL: https://github.com/apache/incubator-superset/pull/10981


   ### SUMMARY
   The goal is to replace all uses of `reactable-arc` library with DataTable 
from superset-ui (which uses `react-table` under the hood) and keep the UI/UX 
mostly unchanged. The reason for that is that `reactable-arc` has been 
unsupported for 2 years now, uses deprecated lifecycle methods and is 
incompatible with Typescript.
   This PR replaces `reactable-arc` in QueryTable component
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   
![image](https://user-images.githubusercontent.com/15073128/93799605-a9cac980-fc3f-11ea-8de3-938f111ddc1c.png)
   
   After:
   
   
![image](https://user-images.githubusercontent.com/15073128/93799544-93247280-fc3f-11ea-8795-3bbed63b1e87.png)
   
   As you can see, there's an additional field where we can change the items 
per page param. Currently `DataTable` doesn't support not showing this field.
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to