eschutho commented on a change in pull request #10962:
URL:
https://github.com/apache/incubator-superset/pull/10962#discussion_r492261696
##########
File path:
superset-frontend/cypress-base/cypress/integration/dashboard/edit_mode.test.js
##########
@@ -23,34 +23,35 @@ describe('Dashboard edit mode', () => {
cy.server();
cy.login();
cy.visit(WORLD_HEALTH_DASHBOARD);
+ cy.route('POST', '/superset/explore_json/*?dashboard_id=1').as('worldMap');
cy.get('.dashboard-header [data-test=pencil]').click();
});
it('remove, and add chart flow', () => {
- // wait for box plot to appear
- cy.get('.grid-container .box_plot');
-
- cy.get('.fa.fa-trash')
- .last()
+ // wait for world map to appear
+ cy.wait('@worldMap');
+ cy.get('.world_map', { timeout: 60000 })
Review comment:
@graceguo-supercat I agree, I don't think the `box_plot` is the issue.
Apologies for the confusion, I posted this to test the ci while working out
CSRF on Cypress and docker together locally. Will update this test here in a
bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
