kgabryje opened a new pull request #11012:
URL: https://github.com/apache/incubator-superset/pull/11012


   ### SUMMARY
   The goal is to replace all uses of `reactable-arc` library with DataTable 
from superset-ui (which uses `react-table` under the hood) and keep the UI/UX 
mostly unchanged. The reason for that is that `reactable-arc` has been 
unsupported for 2 years now, uses deprecated lifecycle methods and is 
incompatible with Typescript.
   This PR replaces `reactable-arc` in `AlteredSliceTag` component.
   I also changed the logic of `AlteredSliceTag` to rely on rows rather than 
diffs in state, which caused some refactors in the unit tests.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before (the rows don't render - a bug perhaps?):
   
   
![image](https://user-images.githubusercontent.com/15073128/93980659-34fea900-fd7f-11ea-902b-a08450950c67.png)
   
   After:
   
   
![image](https://user-images.githubusercontent.com/15073128/93980546-0aaceb80-fd7f-11ea-9427-68e0236d96b5.png)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to