dpgaspar commented on a change in pull request #10978:
URL:
https://github.com/apache/incubator-superset/pull/10978#discussion_r493448925
##########
File path: superset/databases/utils.py
##########
@@ -44,7 +44,7 @@ def get_indexes_metadata(
def get_col_type(col: Dict[Any, Any]) -> str:
try:
dtype = f"{col['type']}"
- except Exception: # pylint: disable=broad-except
+ except KeyError:
Review comment:
I think that we want the default to be a call to `sqla.type.__str__` and
if that fails (on the comment it fails for `sqla.types.JSON`) then use the
class name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
