graceguo-supercat opened a new pull request #11024: URL: https://github.com/apache/incubator-superset/pull/11024
### SUMMARY Dashboard Edit icon should only clickable when user has edit_permit. Otherwise, user start edit dashboard, but when they save the changes, they will get error message. <img width="343" alt="Screen Shot 2020-09-23 at 10 12 37 AM" src="https://user-images.githubusercontent.com/27990562/94046264-519ddf80-fd85-11ea-9779-f480c56c73b0.png";> ### TEST PLAN CI and manual tests. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #10394 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/27990562/94046264-519ddf80-fd85-11ea-9779-f480c56c73b0.png"](https://user-images.githubusercontent.com/27990562/94046264-519ddf80-fd85-11ea-9779-f480c56c73b0.png"){kind=link}