graceguo-supercat edited a comment on pull request #10963: URL: https://github.com/apache/incubator-superset/pull/10963#issuecomment-698061914
This PR will only focus on dashboard's cache stale logic. i do not want to change current slice cache behavior. #2 if chart **was not modified for ~10 hours**, this means slice entity are not modified, like query parameters, datasource used, it doesn't mean the query results is not modified. For dashboard requests, it only need slice parameters but not query results. Front-end js will use slice parameters to build query, plus dashboard filters. #3: annotations: dashboard has no annotation. If slice's annotation was changed, its `params` and `changed_on` attribute will be changed. changed to the default filters, css rules, etc: these change will affect dashboard metadata, and will change changed_on field. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
