rusackas commented on pull request #10971: URL: https://github.com/apache/incubator-superset/pull/10971#issuecomment-698112778
There's [another PR ](https://github.com/apache/incubator-superset/pull/11033/)open where all the icons are moving over from the design system to the codebase. I'm trying to keep the names matching between Figma and the code, so there's a bit of overlap/misalignment with what's in this PR. In this PR, you're adding a few icons, which are _also_ in the other one, but with different names. Would it be OK to ask for rebasing/renaming when that other PR slides in, lest they both merge and we have duplicates? Mapping (names): cog -> gear minus-circle -> minus plus-circle -> plus FWIW, the emerging standard for naming seems to be underscores in filenames (partly thanks to Figma) and dashes in the name values, as you have it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
