nytai commented on a change in pull request #11054:
URL:
https://github.com/apache/incubator-superset/pull/11054#discussion_r494754663
##########
File path: superset/charts/filters.py
##########
@@ -21,15 +21,14 @@
from sqlalchemy.orm.query import Query
from superset import security_manager
+from superset.connectors.sqla.models import SqlaTable
from superset.models.slice import Slice
from superset.views.base import BaseFilter
-class ChartNameOrDescriptionFilter(
- BaseFilter
-): # pylint: disable=too-few-public-methods
- name = _("Name or Description")
- arg_name = "name_or_description"
+class ChartAllTextFilter(BaseFilter): # pylint: disable=too-few-public-methods
+ name = _("All Text")
+ arg_name = "all_text_charts"
Review comment:
Looks like arg_names share a global namespace? If so, we should add the
the resource name to other filters so there's no confusion/collision.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
